src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc
#42852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39941 Signed-off-by: Darshan Sen <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Apr 26, 2022
|
@addaleax PTAL. |
addaleax
approved these changes
May 4, 2022
RaisinTen
added
the
author ready
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7ff2170 |
RaisinTen
deleted the
src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc
branch
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42852 Reviewed-By: Anna Henningsen <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42852 Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42852 Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42852 Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42852 Reviewed-By: Anna Henningsen <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#42852 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39941
Signed-off-by: Darshan Sen [email protected]